You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Suggestions on how to test this: No functional changes. Just a smoke test on the app.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: Popup dialogs will now automatically resize when the window for the app is resized.
What the popup looks like before resizing the browser:
With auto resizing (New default behavior with Primefaces 11):
Without Auto resizing (Default Behavior with Primefaces 10):
Is there a release notes update needed for this change?: doc/release-notes/8456-upgrade-primefaces.md
Issues:
[x] 1. Edit terms shows restricted file red info banner when no restricted files present, prevents saving. [update] was a weird caching issue. Gone.
[x] 2. Seeing an exception when viewing dv/collection group page:StandardWrapperValve[Faces Servlet]: Servlet.service() for servlet Faces Servlet threw exception
javax.faces.FacesException: Unable to automatically determine the lazy attribute. Either define the lazy attribute on the component or make sure the value attribute doesn't resolve to null. clientId: manageGroupsForm:groupMembers
[x] 3. Exception when creating a copy of template on template listing page, complains about isValid and UI shows template created at null: isValiderr.txt
Note if you refresh the page the above copy disappears. Also, if you view the template it only shows terms not metadata portion.
Deleting guestbook does not automatically disappear from page list, needs page refresh unlike v5.10.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: upgrades Primefaces to version 11 for latest features, security upgrades, etc.
Which issue(s) this PR closes:
Closes #8456 Upgrade to Primefaces 11
Special notes for your reviewer: Basically went through the migration guide to see what may apply to Dataverse (just a couple of style sheet edits) https://primefaces.github.io/primefaces/11_0_0/#/../migrationguide/11_0_0
Suggestions on how to test this: No functional changes. Just a smoke test on the app.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: Popup dialogs will now automatically resize when the window for the app is resized.
What the popup looks like before resizing the browser:

With auto resizing (New default behavior with Primefaces 11):
Without Auto resizing (Default Behavior with Primefaces 10):
Is there a release notes update needed for this change?: doc/release-notes/8456-upgrade-primefaces.md
Additional documentation: None