Gdcc/8746 single version semantics for archiving#8747
Merged
kcondon merged 9 commits intoIQSS:developfrom Jul 28, 2022
Merged
Conversation
…sion-semantics_for_archiving
…sion-semantics_for_archiving
sekmiller
reviewed
Jul 20, 2022
| Get the Archival Status of a Dataset By Version | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Archiving is an optional feature that may be configured for a Dataverse instance. When enabled, this API call be used to retrieve the status. Note that this requires "superuser" credentials. |
Contributor
There was a problem hiding this comment.
Kind.of a quibble, but are we using "installation" as the term here or instance?
Member
Author
There was a problem hiding this comment.
FWIW: A quick scan through the guides shows some of each - installation is more popular. I see a dozen+ 'Dataverse instance' and lots of 'instance' referring to other components.
Member
There was a problem hiding this comment.
FWIW, I prefer "Dataverse installation" to "Dataverse instance".
GDCC/8746-single-version-semantics_for_archiving
Member
Author
|
@sekmiller - I've updated this from #8696 so it has all the changes from that review. Which means comparing against that branch should show just the single version code. |
sekmiller
approved these changes
Jul 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR adds a mechanism for archivers to specify that they only allow archiving for a single version and implements logic to enforce that in the archiving/archival status APIs
Which issue(s) this PR closes:
Closes #8746
Special notes for your reviewer: Review after #8696 as this incorporates the status API updates from that PR. Hopefully that PR can be merged and this will be updated before review.
Suggestions on how to test this: The DRS Archiver (not yet in a PR) is the only archiver that supports single-version mode at present, so testing of this by itself could probably be limited to assuring that the Local archiver still works/still allows you to archive multiple versions.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: Addressed in #8611
Additional documentation: