Skip to content

Validation fix and API call#8788

Merged
rtreacy merged 3 commits intoIQSS:7715-signed-urls-for-external-toolsfrom
GlobalDataverseCommunityConsortium:7715-signed-urls-for-external-tools
Jun 9, 2022
Merged

Validation fix and API call#8788
rtreacy merged 3 commits intoIQSS:7715-signed-urls-for-external-toolsfrom
GlobalDataverseCommunityConsortium:7715-signed-urls-for-external-tools

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Jun 9, 2022

The two commits fix a misconception in the validation routine and then add an api call to test with. I haven't done more than compile this so there could still be bugs. The api call should allow requests POSTing a json object with
"url" - the unsigned url you want (must be exact with any dataset/file id, etc.
"method" - optional - GET is assumed
"timeout" - optional - 10 minutes is assumed
"userId" - optional - the user id string - assumes the superuser using this API.

@coveralls
Copy link

coveralls commented Jun 9, 2022

Coverage Status

Coverage decreased (-0.006%) to 18.867% when pulling 55fafa5 on GlobalDataverseCommunityConsortium:7715-signed-urls-for-external-tools into 7e82009 on IQSS:7715-signed-urls-for-external-tools.

@qqmyers
Copy link
Member Author

qqmyers commented Jun 9, 2022

Also added the JSONUtil methods I've mentioned that make it easy to get JsonObject/JsonArray from a string. The prettyprint methods are already there to go the other way.

@rtreacy rtreacy merged commit 01973ff into IQSS:7715-signed-urls-for-external-tools Jun 9, 2022
@pdurbin pdurbin added this to the 5.12 milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants