Skip to content

IQSS/8846 - Fix HTML tags popup#8849

Closed
qqmyers wants to merge 31 commits intoIQSS:developfrom
GlobalDataverseCommunityConsortium:IQSS/8846-fix_popup
Closed

IQSS/8846 - Fix HTML tags popup#8849
qqmyers wants to merge 31 commits intoIQSS:developfrom
GlobalDataverseCommunityConsortium:IQSS/8846-fix_popup

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Jul 20, 2022

What this PR does / why we need it: Fixes issue. Also fixes a related issue that the popup was not showing on the Edit Template page (i.e. for the dataset description). That may have been broken longer.

Which issue(s) this PR closes:

Closes #8846

Special notes for your reviewer: Looks like the change in how dv_rebind... was called made it's no argument constructor for popoverHTML be the one that initialized the popup. The popup, with the correct title and list of tags is called from the dataset and dataverse pages as well so it looks like just removing the no arg call fixes things.

For the template page, it looks like there hasn't been any call to the popoverHTML function with parameters for a while (the thing that made the dataverse and dataset pages work after removing the line noted above). So - guessing this has been broken earlier.

Suggestions on how to test this:

See issue - 3 places: check the dataset/metadata/description popup and the one in the issue for the dataverse description, and the dataset description in the template edit page. and verify that you see the tags.

Key thing to check is whether the popup is still there after some ajax refresh of the page. (Spot checking by changing the template used for a new dataset (suggested by @scolapasta) suggests it does still work, but perhaps there are other situations where it won't).

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@qqmyers qqmyers requested a review from pdurbin July 20, 2022 19:35
@qqmyers
Copy link
Member Author

qqmyers commented Jul 22, 2022

I'm not sure why this now shows changes to 13 files instead of 2 as in https://github.com/IQSS/dataverse/compare/develop...GlobalDataverseCommunityConsortium:dataverse:IQSS/8846-fix_popup?expand=1 .
Since this was a small PR, I tried a rebase on develop in Eclipse. If we need a new PR, let me know. The difference shown above is all that is supposed to be new to develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 19.736% when pulling a5f567e on GlobalDataverseCommunityConsortium:IQSS/8846-fix_popup into 567e506 on IQSS:develop.

@pdurbin
Copy link
Member

pdurbin commented Jul 22, 2022

@qqmyers bah. Git is a pain. New PR, please, if you don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTML tags popup is blank, doesn't show allowed tags

4 participants