add sleep in FilesIT, clean up assertions #6846#8858
Merged
Conversation
sekmiller
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
FilesIT.testForceReplaceAndUpdate has been failing randomly.
Which issue(s) this PR closes:
Special notes for your reviewer:
If you look at #6846 (comment) you'll see that back in May I identified the line that was failing with a 500 error. In this PR, I added the sleepForLock just before this line.
I also did a tiny bit of clean up of the assertions.
Suggestions on how to test this:
This is a hard one to test since it's so intermittent. Assuming Jenkins is happy with the PR (the tests pass), I vote for merging it and seeing if the intermittent test failures go away, which we'll only know over time.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation:
None.