Conversation
and we don't want that in a check of the terms
FWIW: looking for the dataset.getThumbnailFile.getFileMetadata() in the filesToDelete list fails in the delete from a published version case (assuming getFileMetadata() doesn't return the dynamically created fmd for the new draft version)
qqmyers
left a comment
qqmyers
left a comment
There was a problem hiding this comment.
If you're upgrading from v5.10.1, you should follow all of the v5.11 instructions (reexports, solr schema update, counter-processor notes, etc. - just don't need to deploy that war.) Should those instructions be added here? Or should the upgrade instructions reference v5.11? Maybe two upgrade choices - from v5.11 and from v5.10.1?
|
@qqmyers I think it makes the most sense to adjust the 5.11 release notes to say to use the 5.11.1 war instead? |
Add suggestion on detecting destroyed datasets. Add milestone.
|
FWIW, I am absolutely in favor of removing 5.11 from the release page, and have this serve as a self-contained replacement release. |
| ## Upgrade Instructions | ||
|
|
||
| 0\. These instructions assume that you've already successfully upgraded from Dataverse Software 4.x to Dataverse Software 5 following the instructions in the [Dataverse Software 5 Release Notes](https://github.com/IQSS/dataverse/releases/tag/v5.0). After upgrading from the 4.x series to 5.0, you should progress through the other 5.x releases before attempting the upgrade to 5.11.1. | ||
|
|
There was a problem hiding this comment.
To upgrade from 5.10.1, follow the instructions for installing release 5.11 using the v5.11.1 war file. If you had previously installed v5.11 (no longer available), follow the simplified instructions below.
There was a problem hiding this comment.
This looks great, I'll go ahead and add this. I will also add this sentence/some form thereof to the very top of the release note.
Added some bold-faced upgrade guidelines (using language suggested by @qqmyers and my own)
6 participants
What this PR does / why we need it:
We're working on hotfix release. See the included release notes doc.
I cherry picked commits from https://github.com/GlobalDataverseCommunityConsortium/dataverse/tree/v5.11.1-hotfix (thanks, @qqmyers !).
Which issue(s) this PR closes:
Special notes for your reviewer:
I'm not sure why those extra commits from @kcondon are in there. I branched fromThis was before I fixed the pull request. Now it's properly targeting master instead of develop.v5.11.Also, I put in a PR today to describe how I think we should merge and handle hotfixes (#8877). You can preview it at https://dataverse-guide--8877.org.readthedocs.build/en/8877/developers/making-releases.html
I'm not usually the one to bump version numbers so some extra eyes here would be good.
The release notes are probably not final but I figure we can adjust them in the actual release on GitHub.
Suggestions on how to test this:
I believe we've tested these fixes already but I guess test them the same way?
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Included.
Additional documentation:
None.