Merged
Conversation
Version v5.10.1
and we don't want that in a check of the terms
FWIW: looking for the dataset.getThumbnailFile.getFileMetadata() in the filesToDelete list fails in the delete from a published version case (assuming getFileMetadata() doesn't return the dynamically created fmd for the new draft version)
Add suggestion on detecting destroyed datasets. Add milestone.
Added some bold-faced upgrade guidelines (using language suggested by @qqmyers and my own)
scolapasta
approved these changes
Aug 2, 2022
Member
|
I don't think the flyway name should change. Anyone who deployed 5.11 will have that in the db already and renaming would cause it to be added as a new row and run again. For those who didn't upgrade to 5.11, the flyway name still works. (AFAIK flyway looks in numerical order and applies all the missing ones, not just those associated with the latest version, so the old name should work for this case as well.) |
qqmyers
reviewed
Aug 2, 2022
| InputStream xmlStream = new ByteArrayInputStream(byteArrayOutputStream.toByteArray()); | ||
| DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance(); | ||
| factory.setValidating(true); | ||
| //factory.setValidating(true); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We need the bug fixes from 5.11.1 as well as the version change.
Which issue(s) this PR closes:
Closes #8883
Special notes for your reviewer:
In this pull request should we go ahead and rename
V5.11.0.1__8605-support-archival-status.sql
to
V5.11.1.1__8605-support-archival-status.sql
? Or should we create a separate pull request for that?
Suggestions on how to test this:
Make sure the API test pass.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation:
There's a preview of an updated "making releases" page in the dev guide that covers this "merge hotfix into develop" step: https://dataverse-guide--8877.org.readthedocs.build/en/8877/developers/making-releases.html
Here's that pull request: