Quick fix for a failing harvesting test #8937#8939
Conversation
pdurbin
left a comment
There was a problem hiding this comment.
Looks like a doubling, as discussed. I'm waiting for the Jenkins tests to pass before I merge this.
|
Before increasing that sleep, I ran the test a few times and it was failing about 50% of the time. After doubling it I ran it a few more times and wasn't able to get it to fail. |
|
I'll take a look to see why it bombed once I'm in. |
|
This is kind of insane that the harvesting test is still bombing. So maybe it's not the duration after all. (not sure yet what's up with the other test that failed) |
|
Oh. Was that the wrong sleep interval to increase? - I.e., it may be failing not on account of the set create taking too long, but because we try to create the set before the publish command has completed on the dataset there... |
|
OK, the tests have passed. |
|
Before merging I confirmed that indeed all API tests passed. Again, all we're doing is bumping up the amount of sleep. |
|
Yeah, I edited the comment in the issue, documenting that it wasn't the doubling of the 5 sec. sleep, but an extra sleep added before that step. |
What this PR does / why we need it:
Which issue(s) this PR closes:
Closes #8937
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: