Skip to content

Change setting name#8961

Merged
pdurbin merged 1 commit intoIQSS:developfrom
GlobalDataverseCommunityConsortium:IQSS/8960-change_DRS_setting_name
Sep 7, 2022
Merged

Change setting name#8961
pdurbin merged 1 commit intoIQSS:developfrom
GlobalDataverseCommunityConsortium:IQSS/8960-change_DRS_setting_name

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Sep 7, 2022

What this PR does / why we need it: Updates :DRSArchivalConfig setting name to :DRSArchiverConfig

Which issue(s) this PR closes:

Closes #8960

Special notes for your reviewer:

Suggestions on how to test this: pretty trivial - the new name will be tested by HDC

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 20.042% when pulling adb37a9 on GlobalDataverseCommunityConsortium:IQSS/8960-change_DRS_setting_name into a8af4fd on IQSS:develop.

@qqmyers qqmyers added HDC Harvard Data Commons HDC: 3a Harvard Data Commons Obj. 3A labels Sep 7, 2022
@pdurbin pdurbin added this to the 5.12 milestone Sep 7, 2022
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @qqmyers just explained in standup, there's nothing to change in the guides since the docs are Harvard-specific and hosted elsewhere.

I'm approving this. The intended change looks right.

@pdurbin
Copy link
Member

pdurbin commented Sep 7, 2022

I checked that the API tests passed. We're good. I know I approved this PR but it's such a trivial change, housekeeping really, that I'm going to merge it. One fewer PR in QA that way. 😄

@pdurbin pdurbin merged commit f9c1a02 into IQSS:develop Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HDC Harvard Data Commons HDC: 3a Harvard Data Commons Obj. 3A

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update name of DRS Archiver setting to match S3 pattern

3 participants