Merged
Conversation
Contributor
Author
|
Merge conflicts caused by #9616 efforts have been resolved. |
Contributor
Author
|
Updated URLs in the "classic dev environment". Hoping for a positive review 🤞 |
Contributor
Author
|
Fixed merge conflict caused by merging #9796. |
qqmyers
approved these changes
Oct 30, 2023
Member
qqmyers
left a comment
There was a problem hiding this comment.
Straight-forward http -> https cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This updates (almost) all HTTP URLs found in the documentation and code to HTTPS. It increases privacy of readers and may even save some time if the HTTP address needs to redirect to the HTTPS address.
Which issue(s) this PR closes:
I found the HTTP URLs after looking at #9054, but this is unrelated.
Special notes for your reviewer:
I manually checked that the HTTPS URLs resolve. Some do redirect to updated URLs, but I only updated the URL if the content matched the expected content. There may be exceptions to this rule.
I couldn't access the Phoenix server, so I kept those URLs the same.
Suggestions on how to test this:
For now, you could scan the changes and perhaps sample a few URLs to see that resolve to what you would expect.
In the future, you could use an automatic link checker.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
It does change the template of the Guides, so changes may be recognised on many users.
Is there a release notes update needed for this change?:
N/A
Additional documentation: