8724 update datasets of linked dataverse#9304
Merged
Conversation
scolapasta
approved these changes
Jan 23, 2023
Contributor
I could not reproduce the linking issues from #7430 but I used relatively sparse collections so may have avoided some collision? However, I did notice I can link parent collections into child collections, which seems like it shouldn't work due to circular link but seems to. Not sure if that is intentional or just happened but it exists in prior version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Datasets that are children of linked dv collections were not being displayed in the linking dv collection. This PR fixes the indexing of datasets that are children of linked dv collections so that they are displayed as part of the linking dv collection. It also fixes an as far as I can tell, unreported issue where if you link a dv collection that itself has child dv collections those children will look as if they are linked to themselves.
With respect to 7430 noted below as closed, it was reported in version 5.1.1 and was unreproducible in the current version. An integration test exercising the issue has been enabled as part of the PR.
Which issue(s) this PR closes:
Closes #8724 Linking Dataverse does not update child dataset indexes
#7430 Linked Dataverses don't always show up in their linking Dataverses
Special notes for your reviewer:
Suggestions on how to test this: Please make sure that I didn't miss something when I was unable to reproduce 7430.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Release notes have been added. for the changes to be effective for collections that have already been linked those collections must be re-indexed. Instructions for getting a list of those collections for re-indexing is included.
Additional documentation: