Add Shib attribute characterset conversion to getValueFromAssertion

[PaulBoon]

What this PR does / why we need it:
Adds optional Shib attribute characterset conversion to getValueFromAssertion

Which issue(s) this PR closes:

• Closes ShibAttributeCharacterSetConversionEnabled has no influence on affiliation #8573

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

[PaulBoon]

This has not been tested. Also we might want to throw an exception and have the init() return as is done for the required fields.

[PaulBoon]

@pdurbin We are running this in production for some time now, whithout any problems. Could this small change be merged in the next version please?

[pdurbin]

@cmbz @scolapasta how do you feel about getting this fix in?

[cmbz]

@pdurbin I have no objection. @scolapasta?

[pdurbin]

@PaulBoon I'm afraid there are merge conflicts. Do you mind resolving them?

[PaulBoon]

@pdurbin Should be OK now.
BTW the added code is just the same as in getRequiredValueFromAssertion.

[pdurbin]

Thanks. I didn't test this but the change makes sense. Approved.

[ofahimIQSS]

@PaulBoon Can you please add testing steps for this ticket. Thank you!

[PaulBoon]

Testing is difficult because we don't have a testIdp where we can fake an affiliation.
But now that I had a peek at the code change, I do see it is wrong; it is now not mapping to StandardCharsets.UTF_8

[PaulBoon]

@ofahimIQSS I was hoping someone involved with the original issue or code for the getRequiredValueFromAssertion could test it.

[ofahimIQSS]

@PaulBoon Hey Paul - does your institution show up on the list of Institutions and when you login, is your information garbled or can you make it garbled? This is on https://demo.dataverse.org/ - Can you reproduce the bug there and paste a screenshot?

[pdurbin]

I'm having trouble reproducing the bug. In the issue (#8573) the suggestion was to use "Universität", but it seems to work fine, at least when I use :DebugShibAccountType as described at https://guides.dataverse.org/en/6.4/developers/remote-users.html#shibboleth-and-oauth

Maybe we need a real Shibboleth setup to test with? And access to an account that has "Universität" or similar to test with?

Anyway, here are screenshots from my test:

Here's a commit I pushed for the above to a test branch: 28b6779

Again, I'm not sure how to reproduce the bug. 🤷

[PaulBoon]

@ofahimIQSS Sorry for my late reply, I tend to ignore my mailbox regulary. About the login, the dropdown with institutes looks fine, but I can not find my institute (DANS), also not KNAW.

[PaulBoon]

@pdurbin That you could not reproduce the problem might have to do with the input, I mean that string was probably all ready in UTF-8 when you entered it?

[pdurbin]

@PaulBoon probably. The whole file is UTF-8:

% file ~/Downloads/ShibUtil.java 
/Users/PDurbin/Downloads/ShibUtil.java: Java source, Unicode text, UTF-8 text

[PaulBoon]

Unless I made a copy error, it should work because I assume the existing code in getRequiredValueFromAssertion is correct, which I copied into getValueFromAssertion.
So, testing is gold, but we could go for code inspection (silver or bronze?) instead.

@pdurbin You could get the test working with the obvious reverse; new String("SNPP;Universität".getBytes(StandardCharsets.UTF_8), StandardCharsets.ISO_8859_1);

[pdurbin]

@PaulBoon good idea. I tried this in PaulBoon@368bcc9 but "Universität" still looks fine.

I can't push to your branch, by the way. That's why I created PaulBoon#9

[ofahimIQSS]

No issues found during Regression. Merging PR.

testing.shib.mov