9488 internationalization issues

[JayanthyChengan]

Which issue(s) this PR closes:

• Closes Internationalization issues where English text is appearing in UI and system-generated emails #9488

[coveralls]

Coverage: 20.184%. Remained the same when pulling 143ec9b on scholarsportal:9488_InternationlizationIssues into 97310b3 on IQSS:develop.

[pdurbin]

@JayanthyChengan thanks for the pull request!

These seem like straightforward changes. Standard "move English into properties files" stuff.

I gave this PR a 3 in term of effort to review (which I've basically done) and QA.

[qqmyers]

Looks good. I see in the notes @pdurbin has reviewed as well. FOr @kcondon - the issue has details about where the fixes should be visible.

[qqmyers]

FWIW: #9451 has a couple of the same fixes.

[pdurbin]

@JayanthyChengan hi! Can you please resolve the merge conflicts in this pull request? They're in this file:

diff --cc src/main/webapp/file-download-button-fragment.xhtml
index 322bd58906,cecc7ef8d0..0000000000
--- a/src/main/webapp/file-download-button-fragment.xhtml
+++ b/src/main/webapp/file-download-button-fragment.xhtml
@@@ -12,7 -12,7 +12,11 @@@
      xmlns:iqbs="http://xmlns.jcp.org/jsf/composite/iqbs">
      
      <!-- Access Status -->
++<<<<<<< HEAD
 +    <li class="dropdown-header">#{bundle['dataset.accessBtn.header.fileaccess']} <span class="glyphicon glyphicon-file"/></li>
++=======
+     <li class="dropdown-header">#{bundle['file.accessBtn.header.access']} <span class="glyphicon glyphicon-file"/></li>
++>>>>>>> develop
      <li><span class="dropdown-item-text">
              <span class="#{!fileMetadata.restricted ?
                             'glyphicon glyphicon-globe text-success' : (!fileDownloadHelper.canDownloadFile(fileMetadata) ? 'glyphicon glyphicon-lock text-danger' : 'icon-unlock text-success')}"/>
@@@ -211,7 -211,7 +215,11 @@@
      <!-- END: CAN DOWNLOAD ACCESS Options -->
      
      <!-- Download Metadata -->
++<<<<<<< HEAD
 +    <li class="dropdown-header">#{bundle['dataset.accessBtn.header.downloadmetadata']} <span class="glyphicon glyphicon-download-alt"/></li>
++=======
+     <li class="dropdown-header">#{bundle['file.accessBtn.header.metadata']} <span class="glyphicon glyphicon-download-alt"/></li>
++>>>>>>> develop
      
      <ui:fragment rendered="#{fileMetadata.dataFile.tabularData and fileDownloadHelper.canDownloadFile(fileMetadata)}">
          <li>

[pdurbin]

Like @qqmyers said this PR is probably the cause:

• Replaced hard coded strings in File Access button by new Bundle properties #9451

We merged it a couple hours ago.

[JayanthyChengan]

@pdurbin - resolved the conflicts

[pdurbin]

@JayanthyChengan thank you! And I see @qqmyers already moved this to QA. Great!

The only failing test...

https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-9493/4/testReport/edu.harvard.iq.dataverse.api/DatasetsIT/testCuratePublishedDatasetVersionCommand/

... will be fixed by this PR:

• External Exporters bug fix #9632

[kcondon]

@JayanthyChengan When I clicked signup, I got a 500 error in the ui and this server.log error:
signup_svr_log_err.txt

[JayanthyChengan]

@kcondon - Committed the correction

[kcondon]

@JayanthyChengan Thanks! I'm ready to merge it.