Skip to content

Comments

intermittent harvest tests failures #9240#9520

Merged
kcondon merged 2 commits intodevelopfrom
9240-harvest-test-failure
Apr 13, 2023
Merged

intermittent harvest tests failures #9240#9520
kcondon merged 2 commits intodevelopfrom
9240-harvest-test-failure

Conversation

@landreev
Copy link
Contributor

@landreev landreev commented Apr 12, 2023

What this PR does / why we need it:

When the tests in HarvestingClientsIT were creating clients, they would use a random string 6 characters long for the identifier. Our "random strings" are random numbers in hex. But the identifier in this particular class has the constraint such that the string should not contain decimal digits only. So with the generation method above, the expected probability of a constraint violation should therefore be 0.625^6 = roughly 5.96% of the time. Which seems about right, as to the failure rate we've been seeing.

I'm pretty sure we've run into this with dataverse aliases in the past.

Which issue(s) this PR closes:

Closes #9240

Special notes for your reviewer:

I acknowledge that it's not awesome, the behavior of the api - the 500 it throws because of the constraint. I just wanted to keep this pr purely about fixing the test. The harvesting clients api in question is for admins only; and nobody will ever use it particularly frequently. So maybe we can fix this error handling one day... when everything else in the application is fixed.

Suggestions on how to test this:

Seeing how the natural probability of failure was really low (i.e., it would keep passing most of the times if left as is), it would be difficult to confirm for sure that it's not going to happen again, ever. Just confirming that the test passes in the next jenkins run should be QA enough to merge it. If it starts failing again for whatever reason, we'll know soon enough.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@pdurbin pdurbin self-assigned this Apr 13, 2023
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this fix. Approved!

@pdurbin pdurbin removed their assignment Apr 13, 2023
@kcondon kcondon self-assigned this Apr 13, 2023
@kcondon kcondon merged commit 072213b into develop Apr 13, 2023
@kcondon kcondon deleted the 9240-harvest-test-failure branch April 13, 2023 20:20
@pdurbin pdurbin added this to the 5.14 milestone May 10, 2023
@cmbz cmbz added FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) and removed FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Intermittent error from the new Harvesting Clients test

4 participants