Merged
Conversation
pdurbin
approved these changes
May 19, 2023
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
Looks good to me.
The failing Jenkins job is something unrelated: TASK [dataverse : install NodeJS packages from package.json] ******************* https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-9602/1/consoleFull
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: #9257 added a flyway script that is misnamed - starting with V5.13.0.4__ while the next open slot as it ended up being merged is V5.13.0.1__. This PR makes the name change.
Which issue(s) this PR closes:
Closes #
Special notes for your reviewer: I verified that the script can be rerun.
Suggestions on how to test this: On an existing database, one has to drop the V5.13.0.4__* entry in the flyway_schema_history table to be able to redeploy Dataverse. One could just check that this works. Additionally one could check that a fresh deploy works (I can't see how this would fail) and/or verify that the contents of the fileaccessrequests table is the same before and after the redeploy (both content and the constraints, etc.).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: When this is merged, developers should probably get the standard email about having to resolve the flyway conflict on existing databases.