Merged
Conversation
Member
Author
landreev
approved these changes
Jun 21, 2023
Contributor
landreev
left a comment
landreev
left a comment
There was a problem hiding this comment.
Seems straightforward. I would just add a line to "how to test" and suggest to validate the resulting DDI against the schema. CESSDA Metadata Validator (https://cmv.cessda.eu/#!validation) is a good tool.
landreev
reviewed
Jun 21, 2023
| JsonArrayBuilder ldtArr = Json.createArrayBuilder(); | ||
| for(DataTable dt: ldt){ | ||
| ldtArr.add(jsonObjectBuilder().add("dataTable", JsonPrinter.json(dt))); | ||
| ldtArr.add(JsonPrinter.json(dt)); |
Contributor
There was a problem hiding this comment.
I did not notice this line when I was reviewing.
Contributor
|
(As I confessed in the linked issue, I did not fully understand the significance of this PR when I reviewed it - I thought it was only fixing the order of the xml entries, totally missed the part that the entire DDI data desc. section was missing. Happy to see it merged. Thank you @qqmyers and @kcondon) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Per discussion in #9481, a more complex example files showed additional bugs in the updated DDI exporter. This PR fixes those errors.
Which issue(s) this PR closes:
Closes #
Special notes for your reviewer:
Suggestions on how to test this: Use the file from #9481 renamed with a .sav extension and verify that the DDI metadata export exists and includes a section. The file should nominally be the same as for v5.13 except for minor ordering differences, e.g. between the entries. An example DDI export output for this file is attached below.
From @landreev: I would also confirm that the resulting DDI is valid against the schema. I like to use CESSDA Metadata Validator (https://cmv.cessda.eu/#!validation).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: