9667 - displayFormat added to DatasetFieldType API payload#9668
Merged
9667 - displayFormat added to DatasetFieldType API payload#9668
Conversation
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
qqmyers
approved these changes
Jul 5, 2023
Member
qqmyers
left a comment
qqmyers
left a comment
There was a problem hiding this comment.
Looks good - just requesting text changes in the release note contribution.
| @@ -0,0 +1 @@ | |||
| DatasetFieldType attribute "displayFormat", is now returned by the API. | |||
Member
There was a problem hiding this comment.
Should reference the API call involved and make it clearer that goes in the backward compatibility section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add displayFormat to the metadata block fields payload, as required by IQSS/dataverse-client-javascript#63
Which issue(s) this PR closes:
Special notes for your reviewer:
N/A
Suggestions on how to test this:
New field retrieval can be tested via curl:
curl -H "X-Dataverse-Key: <API_KEY>" -X GET http://localhost:8080/api/v1/metadatablocks/citationIs there a release notes update needed for this change?:
Not sure, since it is a very simple addition. I have added a release note md, just in case.
Additional documentation:
N/A