Skip to content

Comments

Update for #9677#9695

Merged
kcondon merged 5 commits intoIQSS:developfrom
GlobalDataverseCommunityConsortium:DANS-external_exporters
Jul 6, 2023
Merged

Update for #9677#9695
kcondon merged 5 commits intoIQSS:developfrom
GlobalDataverseCommunityConsortium:DANS-external_exporters

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Jul 5, 2023

What this PR does / why we need it: The fix from #9677 removed the "restricted" key from the dataset fileDetails provided via the InternalExportDataProvider. Since this detail is not available via the DataFileDTO used in DdiExporterUtil, this PR adds the restricted key back but only when the JsonPrinter method is called from the InternalExportDataProvider. This maintains backward compatibility while fixing the issue. (Further refactoring/updating the DTOs, etc. might be cleaner - e.g. in the context of #9463)

Which issue(s) this PR closes:

Closes #

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@coveralls
Copy link

coveralls commented Jul 5, 2023

Coverage Status

coverage: 20.371% (-0.001%) from 20.372% when pulling 9ababc5 on GlobalDataverseCommunityConsortium:DANS-external_exporters into f98636d on IQSS:develop.

@qqmyers qqmyers added the Size: 3 A percentage of a sprint. 2.1 hours. label Jul 6, 2023
@kcondon kcondon self-assigned this Jul 6, 2023
@kcondon kcondon merged commit 11b77c4 into IQSS:develop Jul 6, 2023
@pdurbin pdurbin added this to the 5.14 milestone Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: 3 A percentage of a sprint. 2.1 hours.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants