Remove hard-coded English strings from MyData API

[stevenferey]

What this PR does / why we need it:

Which issue(s) this PR closes:

Closes #9292

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

[qqmyers]

Looks good - did not test but the auto-test and QA should be able to verify the messages aren't getting changed.
FWIW: There are a couple weird text strings in the original that this PR faithfully makes internationalizable, i.e. "retrieveMyDataAsJsonString. User not found! Shouldn't be using this anyway.", "Sorry, the EntityManager isn't working (still).". If anyone knows more about when they might appear, perhaps some more user-oriented text could be substituted.

[pdurbin]

I didn't test this but it makes sense. Thanks, @stevenferey! We're in the middle of a platform upgrade only release (6.0), but after that we can try to get this in. I love it when we removed hard-coded English.

[pdurbin]

Ha. The poor translators. What in the world is an EntityManager, they'll wonder.

[stevenferey]

A little more contextualization in this case with: "Sorry, the authenticated user ID could not be retrieved."

[qqmyers]

@stevenferey - looks good - probably needs a merge with develop to get the tests to run again.

[qqmyers]

FWIW: This is still odd, but only shows in the log.

[sekmiller]

@stevenferey This PR has a merge conflict. Please resolve. Also I'm seeing a failing test in DataRetrieverApiIT. Can you please take a look at that? Thanks!

[coveralls]

coverage: 20.586% (-0.004%) from 20.59%
when pulling 36379c6 on Recherche-Data-Gouv:9292-my-data-hardcoded-text
into da3dd95 on IQSS:develop.

[sekmiller]

`
private static final String ERR_MSG_FORMAT = "{\n "success":false,\n "error_message": "%s"\n}";

    assertEquals(prettyPrintError("dataretrieverAPI.user.not.found", Arrays.asList(badUserIdentifier)).replace(" ", ""), invalidUserIdentifierResponse.prettyPrint().replace(" ", ""));


    assertEquals(prettyPrintError("myDataFinder.error.result.no.role", null).replace(" ", ""), validUserIdentifierResponse.prettyPrint().replace(" ", ""));

`

@stevenferey Tests are failing - I was able to get them to pass by making these changes locally. I'm not able to update your repo. Does this make sense? And, if so, can you make the changes. Thanks!

[stevenferey]

Thank you for this feedback,

We have updated the error message format in the test case.

[sekmiller]

Looks good @stevenferey @jeromeroucou

Thanks for the contribution and your patience through the process