9829 Use macos-latest runner for shellspec#9830
Conversation
|
@bencomp do you want to try making a no-op edit to a shell script to trigger the shellspec workflow? From what I see below even something under tests/shell would trigger it? @poikilotherm set this up and would know for sure. |
|
@pdurbin I could try, but I think only workflows that are on the default branch are run – to prevent cryptominer PRs and other bad stuff. So before this is merged even a no-op change should trigger a job for macos-10.15. |
|
Okay, I did manage to test: https://github.com/bencomp/dataverse/actions/runs/5977459978/job/16217490079 🚀 |
|
Ha. Thanks. 😄 On my PR at https://github.com/IQSS/dataverse/actions/runs/5968226464/job/16191594100?pr=9787 I saw the same thing you are: I cherry-picked your commit into my branch: 3944cf1 It seems to have fixed it! Here's the MacOS run: https://github.com/IQSS/dataverse/actions/runs/5977475730/job/16217537483?pr=9787 Some details: I marked my PR as closing the issue you opened: I believe this PR will auto-close when my PR is merged. (Or you can go ahead and close it if you want.) Thanks! Welcome back! 🎉 ❤️ 🚀 |
|
Eh, I will wait and see which is merged first ;) Perhaps you want to cancel the queued jobs that are waiting for the old runners? |
|
Issue was solved in #9787 |
What this PR does / why we need it:
It updates the Shellspec workflow to use the newer MacOS runners, since the
macos-10.15are no longer available causing all Shellspec workflow to fail after being queued for a day.Which issue(s) this PR closes:
Closes #9829
Special notes for your reviewer:
I assume that shellspec works the same on MacOS 11 and up as on MacOS 10.15. I have not tested this.
Suggestions on how to test this:
See that the new jobs pass.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Maybe; if release notes (should) include MacOS compatibility notes, then yes.
Additional documentation: