Open
Conversation
1 task
Dontmerge comment out logs
davidkeymer
reviewed
Dec 9, 2024
| adsConnection->resolve_variables(ads_read_vars)); | ||
|
|
||
| if (status) { | ||
| if (status && lastReadError != status) { |
There was a problem hiding this comment.
Logic not quite right here. Need two 'if' statements to return status regardless.
if (ads_read_vars.size()) {
status = static_cast<asynStatus>(
adsConnection->resolve_variables(ads_read_vars));
if (status) {
if (lastReadError!= status){
LOG_ERR_ASYN(pasynUser,
"Could not resolve ADS read variable names (%i): %s",
status, ads_errors[status].c_str());
lastReadError = status;
}
return status;
}
lastReadError = 0;
}Also applies to further 'if' statements, for write and sumread.
|
|
||
| #define LOG_WARN_ASYN(asyn_user, format, ...) \ | ||
| LOG_MSG_ASYN(asyn_user, ASYN_TRACE_WARNING, "WARNING", format, ##__VA_ARGS__) | ||
| //LOG_MSG_ASYN(asyn_user, ASYN_TRACE_WARNING, "WARNING", format, ##__VA_ARGS__) |
There was a problem hiding this comment.
Would rather keep these messages in case useful. Different case to above where repeated messages were lost.
| } | ||
| return EPICSADS_NOT_RESOLVED; | ||
| } | ||
| last = ""; |
There was a problem hiding this comment.
Do we need to reset last variable here? Could be done in the header file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISISComputingGroup/IBEX#8406