Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 75.49% 74.59% -0.91%
==========================================
Files 29 29
Lines 1106 1106
==========================================
- Hits 835 825 -10
- Misses 271 281 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
Do you want me to add that change to this PR as well? |
Member
Author
I'll merge this and we can do that in a followup PR, I think that would require other updates for SparseArraysBase.jl v0.3 anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63, using the same code pattern that was used in ITensor/NamedDimsArrays.jl#48.
The show methods also have to be updated to reflect the changes @lkdvos made in ITensor/SparseArraysBase.jl#31, but this is orthogonal to that issue since this PR is only about how the types are printed, not how the unstored values are printed.