This repository was archived by the owner on Jan 8, 2026. It is now read-only.
Add DefaultArrayInterface methods#11
Merged
mtfishman merged 5 commits intoITensor:mainfrom Jan 13, 2025
lkdvos:ld-errors
Merged
Add DefaultArrayInterface methods#11mtfishman merged 5 commits intoITensor:mainfrom lkdvos:ld-errors
DefaultArrayInterface methods#11mtfishman merged 5 commits intoITensor:mainfrom
lkdvos:ld-errors
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 39.61% 38.41% -1.20%
==========================================
Files 9 9
Lines 308 315 +7
==========================================
- Hits 122 121 -1
- Misses 186 194 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Also fixes #10 |
mtfishman
approved these changes
Jan 13, 2025
Member
mtfishman
left a comment
mtfishman
left a comment
There was a problem hiding this comment.
Looks good to me, feel free to merge.
Contributor
Author
|
(I still don't have the right privileges to do this) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some missing implementations for
DefaultArrayInterface, which are not defined forAbstractArrayInterface.Additionally, it closes #10 to make the tests pass, and updates the skeleton to make the tests run.