Add diagonal as a generalization of LinearAlgebra.Diagonal#4
Merged
mtfishman merged 7 commits intoITensor:mainfrom Jan 10, 2025
Merged
Add diagonal as a generalization of LinearAlgebra.Diagonal#4mtfishman merged 7 commits intoITensor:mainfrom
diagonal as a generalization of LinearAlgebra.Diagonal#4mtfishman merged 7 commits intoITensor:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 77.20% 77.37% +0.16%
==========================================
Files 11 11
Lines 136 137 +1
==========================================
+ Hits 105 106 +1
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
Looks good, thanks. Can you add a test? Also, I guess we should start listing docstrings in the docs... |
Contributor
Author
|
I tried something out to make a |
mtfishman
reviewed
Jan 10, 2025
mtfishman
reviewed
Jan 10, 2025
diagonaldiagonal as a generalization of LinearAlgebra.Diagonal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a utility entrance-point to turn a vector into a diagonal matrix, without implying the return type. Specifically, it adds
diagonal, which relates toDiagonalin the same way thatadjointrelates toAdjoint.The main purpose is to have the ability to write generic code, without having to force everything to be of type
Diagonal.