Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
===========================================
+ Coverage 62.54% 75.05% +12.51%
===========================================
Files 6 7 +1
Lines 283 421 +138
===========================================
+ Hits 177 316 +139
+ Misses 106 105 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a sparse type that only stores a single structurally nonzero element. This is very similar to
FillArrays.OneElement, but I'm reimplementing a version here for better compatibility with the sparse types we are developing, and to have more control over the operations we define. See alsoOneHotArrays.OneHotArrayfor a similar type.A lot of algebra operations "just work" for this type, but don't yet necessarily preserve the
OneElementArraytype (when that is possible) and instead fall back to generic code that constructsSparseArrayDOK, for example:Note that most of the code is defining various constructors, and probably that can be simplified.
The idea is that this will serve as the basis for the next-generation
oneelementfunction for constructing ITensors with a single element, see ITensor/ITensorBase.jl#26.