sparse constructor, zero value to kwarg, constructors with splatted dims#43
Merged
sparse constructor, zero value to kwarg, constructors with splatted dims#43
sparse constructor, zero value to kwarg, constructors with splatted dims#43Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 71.49% 74.88% +3.39%
==========================================
Files 7 7
Lines 435 450 +15
==========================================
+ Hits 311 337 +26
+ Misses 124 113 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sparse constructor, zero value to kwarg, constructors with splatted dimssparse constructor, zero value to kwarg, constructors with splatted dims
lkdvos
approved these changes
Mar 6, 2025
lkdvos
approved these changes
Mar 6, 2025
This was referenced Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40, fixes #42.
Also turns the function used by
getunstoredindexinto a keyword argument calledgetunstored(before it was an argument, which wasn't good for constructors where the dims are splatted).To-do