Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 71.36% 71.49% +0.13%
==========================================
Files 7 7
Lines 433 435 +2
==========================================
+ Hits 309 311 +2
Misses 124 124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I missed that I actually had made basically the same definition of Probably we can make more of the sparse array definitions for wrappers more general, but I'd prefer to leave that for a future PR since I think that is more involved. |
This generalizes a definition originally made in ITensor/BlockSparseArrays.jl#74, with the goal of fixing ITensor/BlockSparseArrays.jl#73.
@lkdvos ideally this code would handle things like linear indexing but that system is being rewritten in #39 so for now I'm just following the style of how other
isstoredfunctions are defined.