Skip to content

Added ranking prior to permutation testing #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarthakpati merged 9 commits into from
Jul 31, 2025
Merged

Added ranking prior to permutation testing #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
02c190e
Set default value for metrics_for_reversal to an empty string in run.py
sarthakpati Jul 15, 2025
df66b55
revert
sarthakpati Jul 15, 2025
da42623
Set default value for metrics_for_reversal to an empty string in run.py
sarthakpati Jul 15, 2025
49d0ba6
Sort ranks by cumulative rank in the Ranker class
sarthakpati Jul 15, 2025
5e13ae1
Sort ranks by cumulative rank and sanitize the DataFrame in the Ranke…
sarthakpati Jul 15, 2025
866f40d
Update pyranker/ranker.py
sarthakpati Jul 15, 2025
0bbbde4
Refactor sorting of ranks per metric for improved readability
sarthakpati Jul 15, 2025
2a4b0ef
Update .gitignore to include data/output* and ensure newline at end o…
sarthakpati Jul 15, 2025
b97c948
Update tests.yml
sarthakpati Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]
branches: [ "*" ]

permissions:
contents: read
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,4 +131,5 @@ dmypy.json
# vs code
.vscode/
data_private/
test_output/
test_output/
data/output*
2 changes: 1 addition & 1 deletion pyranker/cli/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def main(
"--metrics-for-reversal",
help="The comma-separated metric columns for which the reversal should be calculated; for example, 'hausdorff_tc,hausdorff_et'.",
),
] = None,
] = "",
iterations: Annotated[
int,
typer.Option(
Expand Down
7 changes: 6 additions & 1 deletion pyranker/ranker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,12 @@ def perform_permutation_test(self) -> None:
n_methods = len(self.ranks_per_metric)
self.pvals = np.zeros((n_methods, n_methods))

ranks_per_metric_sanitized = self.ranks_per_metric.drop(
# sort in order of cumulative rank and reset index in one step
ranks_per_metric_sorted = self.ranks_per_metric.sort_values(
by="cumulative_rank"
).reset_index(drop=True)

ranks_per_metric_sanitized = ranks_per_metric_sorted.drop(
columns=["method", "cumulative_rank", "final_rank"]
)

Expand Down