This repository was archived by the owner on Jun 23, 2023. It is now read-only.
Refactor scopes configuration#130
Merged
peppelinux merged 4 commits intoIdentityPython:developfrom Sep 20, 2021
Merged
Conversation
nsklikas
requested review from
peppelinux and
rohe
and removed request for
rohe
Collaborator
|
Sorry, should have reply long time ago. Was busy elsewhere. |
rohe
approved these changes
Sep 20, 2021
nsklikas
force-pushed
the
feature-refactor-scopes
branch
from
109d83a to
65b3388
Compare
nsklikas
force-pushed
the
feature-refactor-scopes
branch
from
65b3388 to
fcb4890
Compare
peppelinux
approved these changes
Sep 20, 2021
Member
peppelinux
left a comment
peppelinux
left a comment
There was a problem hiding this comment.
Thanks to Roland that triggers a message to me automatically, I was fare from this thread for days ...
Yes, I appreciated the issue and this pr as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went ahead and implemented the behavior described in #127. I hope you agree with my approach.
If this PR is merged then the
custom_scopesadd on should be deprecated. I didn't delete it in case someone uses it in his installation but added a warning.Closes #127