Skip to content
This repository was archived by the owner on Jun 23, 2023. It is now read-only.

feat: add RawID to session manager#149

Merged
peppelinux merged 2 commits intoIdentityPython:developfrom
melanger:patch-2
Nov 5, 2021
Merged

feat: add RawID to session manager#149
peppelinux merged 2 commits intoIdentityPython:developfrom
melanger:patch-2

Conversation

@melanger
Copy link
Copy Markdown
Contributor

@melanger melanger commented Nov 2, 2021

allow passing already hashed IDs from backends or hashing in a microservice instead

rohe and others added 2 commits October 27, 2021 17:03
chore: README full of badges for the younger
allow passing already hashed IDs from backends or hashing in a microservice instead
@peppelinux
Copy link
Copy Markdown
Member

peppelinux commented Nov 2, 2021

Ciao @melanger

unfortunately we have these subject types following the oidc official specs, here:
https://openid.net/specs/openid-connect-core-1_0.html#SubjectIDTypes

Consider to install your own python package and configure it in your oidcop sub functions (you have them in the general configuration)

anyway I ask a revision to other friends that helps in releasing new versions of oidcop

@peppelinux peppelinux changed the base branch from master to develop November 2, 2021 09:12
@melanger
Copy link
Copy Markdown
Contributor Author

melanger commented Nov 2, 2021

@peppelinux I don't mean it as a new subject type (such as subject_type=raw), but as an alternative implementation of public ID. Maybe it could be RawPublicID? But yes, I can put this into a separate module.

The reason for this proposal is that with PublicID and SubjectID from oidcop it is not possible to use anything else than a SHA256 hash of userID+section_identifier+salt. It is not possible to use a raw user attribute (e.g. I already have eduPersonUniqueID so I do not need to hash it again) or to do other hashing (e.g. use the Hasher microservice in SATOSA instead).

@peppelinux
Copy link
Copy Markdown
Member

@melanger I understand perfectly!
let's take some more days and wait for the revision of roland and nikos, there's no hurry

@peppelinux peppelinux merged commit 5e04682 into IdentityPython:develop Nov 5, 2021
@melanger melanger deleted the patch-2 branch November 29, 2021 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants