Open
Conversation
LydiaKoil
reviewed
Mar 19, 2023
| %a.font-medium.text-emerald-700.hover:text-emerald-800{href: new_user_session_path} Sign in | ||
| .mt-8.sm:mx-auto.sm:w-full.sm:max-w-md | ||
| .bg-white.py-8.px-4.shadow.sm:rounded-lg.sm:px-10 | ||
| = form_for(resource, as: resource_name, url: url: registration_path(@user), method: :put, html: { class: 'space-y-6'}) do |f| |
Contributor
There was a problem hiding this comment.
there's a method: :put here accidentally - that's causing the error I think - its going to the wrong place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think pure white all white including cards doesn't work well, some color is needed so when with the super light version of emerald as background
emerald-50. also large shadows.Some other guidelines for buttons links etc. Hover states should be a higher color than the default so meaning if the button is
bg-emarald-700the hover should bebg-emerald-800Also I could only get these 2 done because there were too many errors and I didn't want to touch backend code much. Maybe Im doing something wrong with running (do I need to do some extra things) or things aren't pushed yet?