fix: align launch timer default to 0-30#653
Open
IgorGanapolsky wants to merge 2 commits intodevelopfrom
Open
Conversation
|
Merging to
|
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
github-actions
bot
added
the
pr-state:ci_running
Contributor
|
❌ CI Some checks failed
|
|
Contributor
|
✅ CI All checks passed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of core commit from
fix/default-range-0-30(PR #642) onto cleandevelop.The original PR had 11-file conflicts. This extracts just the essential fix.
Supersedes PR #642 — close that after this merges.
Change
tests/python/test_timer_defaults_parity.pyverifying launch default is 0–30s rangeTest plan
test_timer_defaults_parity.pypasses🤖 Generated with Claude Code