-
Notifications
You must be signed in to change notification settings - Fork 0
Post-collab guide updates #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
a7c25b0
Rename to CDSG for template guide (#48)
egrace479 f21a768
Small fixes (#51)
egrace479 b4e30e2
Update repo descriptions, attribution, and how to use (#50)
egrace479 924affd
Set up as joint code of conduct for shared space (#53)
egrace479 2da484f
Why use Org GH/HF Generalization (#54)
egrace479 a162243
Update template site homepage (#52)
egrace479 90d8144
feat(contributing): add comprehensive project standards and guideline…
gwtaylor 865c820
Fix pointers to match page names and update nav bar accordingly (#60)
egrace479 09a7668
Add Digital Product Policy tab landing page + life cycle (#59)
egrace479 35851cc
fix life cycle page formatting (#61)
egrace479 c61bfb8
Apply linter to the repo and update rules (#64)
egrace479 30a783a
Revert to Imageomics Guide in refs
egrace479 0d9921f
Revert site descriptors, nav, logos, and acknowledgement footer
egrace479 e60bb84
Add preamble suggesting distinction for more general contributions
egrace479 7d5b10b
Remove template-specific sections, update history
egrace479 1aed4d9
Revert back to just Imageomics
egrace479 e9f64a2
Remove statement referencing template use
egrace479 8aab985
Remove ABC HF templates and refocus to just Imageomics templates
egrace479 1fcc173
Restore to Imageomics-specific
egrace479 41dd00a
Revert to Imageomics focus
egrace479 1c8a394
Remove Canadian part from ABC funding
egrace479 2ecc1e4
Set Collab Guide as reference, adjust authors accordingly
egrace479 df04324
Add padding on logo in header to avoid distortion
egrace479 5bef2ac
Add day of release
egrace479 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,3 +4,6 @@ | |
| # Additional | ||
| __pycache__ | ||
|
|
||
| # MkDocs build output | ||
| site/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,8 @@ | ||
| { | ||
| "MD007": { "indent": 4 }, | ||
| "no-hard-tabs": false, | ||
| "MD013": false | ||
| } | ||
| "MD013": false, | ||
| "MD026": { "punctuation": ".,;:" }, | ||
| "MD040": false, | ||
| "MD046": false | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| docs/wiki-guide/HF_*_Template*.md | ||
| mkdocs.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,234 @@ | ||
| # Contributing to the Imageomics Guide | ||
|
|
||
| Thank you for your interest in contributing to the Imageomics Guide! | ||
|
|
||
| This document outlines the standards and guidelines for contributing to the Imageomics Guide. Before you begin, please review the information provided here. | ||
|
|
||
| First, is your contribution specific to Imageomics, or would it be more broadly applicable? If more general, please consider instead directing the update or suggestion to the [Collaborative Distributed Science Guide](https://github.com/Imageomics/Collaborative-distributed-science-guide); updates to the template repository will be incorporated both here and in other other guides developed from it. If it _is_ Imageomics-specific, please continue to review this document—we look forward to your input! | ||
|
|
||
| ## Overview | ||
|
|
||
| The Imageomics Guide is built with [MkDocs Material](https://squidfunk.github.io/mkdocs-material/) and deployed via GitHub Pages. All documentation is written in Markdown and follows specific formatting standards to ensure consistent rendering and maintainability. | ||
|
|
||
| ## Getting Started | ||
|
|
||
| ### Local Development Setup | ||
|
|
||
| 1. Clone the repository | ||
| 2. Set up a virtual environment (recommended): | ||
|
|
||
| ```bash | ||
| python -m venv .venv | ||
| source .venv/bin/activate # On Windows: .venv\Scripts\activate | ||
| ``` | ||
|
|
||
| For more detailed environment setup options (including conda), see our [Virtual Environments guide](docs/wiki-guide/Virtual-Environments.md). | ||
|
|
||
| 3. Install dependencies: | ||
|
|
||
| ```bash | ||
| pip install -r requirements.txt | ||
| ``` | ||
|
|
||
| 4. Serve the site locally: | ||
|
|
||
| ```bash | ||
| mkdocs serve | ||
| ``` | ||
|
|
||
| 5. View the site at <http://127.0.0.1:8000/Imageomics-guide/> | ||
|
|
||
| ### Testing Changes | ||
|
|
||
| Always test your changes locally with `mkdocs serve` before submitting a PR to ensure: | ||
|
|
||
| - Content renders correctly | ||
| - Links work properly | ||
| - Formatting appears as intended | ||
| - No build errors occur | ||
|
|
||
| ## Documentation Standards | ||
|
|
||
| ### Markdown Formatting | ||
|
|
||
| #### Indentation for Nested Lists | ||
|
|
||
| - **Use 4 spaces for nested list items** (not 2 spaces) | ||
| - This requirement exists due to Python-Markdown compatibility issues with MkDocs | ||
| - 2-space indentation causes nested lists to not render properly in the final HTML | ||
|
|
||
| **Correct:** | ||
|
|
||
| ```markdown | ||
| - [ ] Main item | ||
| - [ ] Nested item | ||
| - [ ] Another nested item | ||
| ``` | ||
|
|
||
| **Incorrect:** | ||
|
|
||
| ```markdown | ||
| - [ ] Main item | ||
| - [ ] Nested item (will not render as nested) | ||
| ``` | ||
|
|
||
| #### General Formatting | ||
|
|
||
| - Remove trailing whitespace | ||
| - Use consistent line breaks | ||
| - Follow the project's `.markdownlint.json` configuration | ||
| - Ensure proper heading hierarchy (don't skip heading levels) | ||
|
|
||
| ### License Format Requirements | ||
|
|
||
| #### Hugging Face YAML Frontmatter | ||
|
|
||
| When specifying licenses in Hugging Face dataset/model card YAML sections, **always use lowercase**: | ||
|
|
||
| **Correct:** | ||
|
|
||
| ```yaml | ||
| license: cc0-1.0 | ||
| ``` | ||
|
|
||
| **Incorrect:** | ||
|
|
||
| ```yaml | ||
| license: CC0-1.0 # Will cause issues with Hugging Face platform | ||
| ``` | ||
|
|
||
| This is a platform-specific requirement for Hugging Face compatibility. | ||
|
|
||
| #### License References in Text | ||
|
|
||
| In prose text, you may use standard capitalization (e.g., "CC0", "MIT"), but YAML frontmatter must be lowercase. | ||
|
|
||
| ### File Organization | ||
|
|
||
| - Documentation content goes in `docs/` | ||
| - Wiki-style guides go in `docs/wiki-guide/` | ||
| - Images and assets are organized in subdirectories within `docs/` | ||
| - Templates use descriptive filenames with consistent naming patterns | ||
|
|
||
| ### Custom Macros | ||
|
|
||
| The project includes custom MkDocs macros defined in `main.py`: | ||
|
|
||
| - `include_file_as_code()` - Embeds file content as code blocks | ||
| - When using macros, ensure proper syntax and test rendering locally | ||
|
|
||
| ## Contribution Process | ||
|
|
||
| 1. **Create an issue** describing the change (for significant additions) | ||
| 2. **Create a feature branch** from `dev` | ||
| 3. **Make your changes** following the standards above | ||
| 4. **Test locally** with `mkdocs serve` | ||
| 5. **Run linting (OPTIONAL)** to ensure formatting consistency | ||
| - See instructions in [Linting](#linting) | ||
| 6. **Submit a pull request** with: | ||
| - Clear description of changes | ||
| - Reference to related issue | ||
| - Screenshots if UI changes are involved | ||
|
|
||
| ### Pull Request Guidelines | ||
|
|
||
| - Keep PRs focused on a single topic when possible | ||
| - Follow commit message conventions (see below) | ||
| - Update navigation in `mkdocs.yaml` if adding new pages | ||
| - Ensure all links work correctly | ||
| - Test that the site builds without errors | ||
|
|
||
| ### Commit Message Guidelines | ||
|
|
||
| The most important aspects of good commit messages are that they should be **descriptive** and **atomic** (each commit should represent a single logical change). Additionally: | ||
|
|
||
| - **Keep the first line short**: Limit the subject line to 50 characters or less | ||
| - **Use the imperative mood**: "Add feature" not "Added feature" or "Adds feature" | ||
| - **Separate subject from body**: Use a blank line between the subject line and detailed description | ||
|
|
||
| #### Conventional Commits Recommendation | ||
|
|
||
| We recommend following the [Conventional Commits](https://www.conventionalcommits.org/) format for commit messages: | ||
|
|
||
| **Format:** `type(scope): description` | ||
|
|
||
| **Common types:** | ||
|
|
||
| - `feat`: New feature or content addition | ||
| - `fix`: Bug fix or correction | ||
| - `docs`: Documentation updates | ||
| - `style`: Formatting changes (no content changes) | ||
| - `refactor`: Code/content restructuring without changing functionality | ||
| - `chore`: Maintenance tasks, tooling updates | ||
|
|
||
| **Examples:** | ||
|
|
||
| ```bash | ||
| feat(fair-guide): add data repository checklist | ||
| fix(templates): correct license format in HF dataset card | ||
| docs(contributing): add conventional commit guidelines | ||
| style(checklists): fix markdown formatting and indentation | ||
| chore: update mkdocs dependencies | ||
| ``` | ||
|
|
||
| **Scope** is optional but helpful for larger changes. Use the guide section or file type being modified. | ||
|
|
||
| **Note:** Since we use squash merges, strict adherence to this format isn't required, but descriptive and atomic commits help maintain a clear project history. | ||
|
|
||
| ## Quality Assurance | ||
|
|
||
| ### Linting | ||
|
|
||
| The project uses [markdownlint](https://github.com/DavidAnson/markdownlint) with configuration in `.markdownlint.json`. Key settings: | ||
|
|
||
| - 4-space indentation for lists (`MD007`). | ||
| - No hard tab restrictions disabled. | ||
| - Line length restrictions disabled (`MD013`). | ||
| - Restrict punctuation in headers (`MD026`); allow `!` and `?`. | ||
| - Allowed code blocks without language specification (`MD040`). | ||
| - Allow fenced code blocks, as this commonly errors when indented (see [discussion](https://github.com/DavidAnson/markdownlint/issues/327)). | ||
|
|
||
| For faster PR review, you may want to run linting locally; we do have a PR Action in place as well. First install markdownlint, then run | ||
|
|
||
| ```console | ||
| markdownlint -c .markdownlint.json -f docs/wiki-guide/ | ||
| ``` | ||
|
|
||
| The `-f` resolves simple formatting issues, and alerts will be raised for more complicated linter style rules (e.g., referencing a link as `[here](URL)` will produce the line: `<filename>.md:191:2 MD059/descriptive-link-text Link text should be descriptive [Context: "[here]"]`). | ||
|
|
||
| ### Content Review | ||
|
|
||
| When reviewing content: | ||
|
|
||
| - Verify accuracy of technical information | ||
| - Check for consistency with existing guides | ||
| - Ensure proper cross-referencing between related pages | ||
| - Validate that external links are current and working | ||
|
|
||
| ## Platform-Specific Considerations | ||
|
|
||
| ### Hugging Face Integration | ||
|
|
||
| - Dataset and model card templates must follow HF specifications | ||
| - YAML frontmatter formatting is critical for platform compatibility | ||
| - License identifiers must match HF's expected format | ||
|
|
||
| ### MkDocs/Python-Markdown | ||
|
|
||
| - Nested list rendering requires specific indentation | ||
| - Some Markdown extensions may behave differently than GitHub Flavored Markdown | ||
| - Always test complex formatting locally | ||
|
|
||
| ## Getting Help | ||
|
|
||
| - Open an [issue](https://github.com/Imageomics/Imageomics-guide/issues) for questions or problems | ||
| - Reference existing guides and templates for examples | ||
| - Check the [MkDocs Material documentation](https://squidfunk.github.io/mkdocs-material/) for advanced features | ||
|
|
||
| ## Code of Conduct | ||
|
|
||
| All contributors must adhere to our [Code of Conduct](docs/CODE_OF_CONDUCT.md) and organizational principles of engagement. | ||
|
|
||
| --- | ||
|
|
||
| Thank you for helping improve the Imageomics Guide! Your contributions help make collaborative scientific computing more accessible and effective. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.