Skip to content

Limit polyfill to only lock type #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viceroypenguin merged 1 commit into from
Feb 9, 2026
Merged

Limit polyfill to only lock type #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@
<IsPackable>false</IsPackable>
</PropertyGroup>

<PropertyGroup Label="Enabled Polyfills">
<!--https://github.com/meziantou/Meziantou.Polyfill?tab=readme-ov-file#supported-polyfills-->
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XML comment formatting: add a space after <!-- for readability/consistency (e.g., <!-- https://... -->).

Suggested change
<!--https://github.com/meziantou/Meziantou.Polyfill?tab=readme-ov-file#supported-polyfills-->
<!-- https://github.com/meziantou/Meziantou.Polyfill?tab=readme-ov-file#supported-polyfills-->

Copilot uses AI. Check for mistakes.
<Polyfill></Polyfill>
<Polyfill>$(Polyfill)|T:System.Threading.Lock</Polyfill>
<MeziantouPolyfill_IncludedPolyfills>$(Polyfill)</MeziantouPolyfill_IncludedPolyfills>
</PropertyGroup>

<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
Comment on lines +21 to 26
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Polyfill></Polyfill> followed by <Polyfill>$(Polyfill)|T:System.Threading.Lock</Polyfill> expands to a value that starts with a leading | (because $(Polyfill) is empty). If MeziantouPolyfill_IncludedPolyfills doesn’t tolerate empty entries, this can prevent the Lock polyfill from being applied (and break net8 builds). Prefer setting MeziantouPolyfill_IncludedPolyfills directly to T:System.Threading.Lock, or append conditionally only when the existing value is non-empty (and avoid the extra Polyfill property altogether).

Suggested change
<Polyfill></Polyfill>
<Polyfill>$(Polyfill)|T:System.Threading.Lock</Polyfill>
<MeziantouPolyfill_IncludedPolyfills>$(Polyfill)</MeziantouPolyfill_IncludedPolyfills>
</PropertyGroup>
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
<MeziantouPolyfill_IncludedPolyfills>T:System.Threading.Lock</MeziantouPolyfill_IncludedPolyfills>
</PropertyGroup>
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">

Copilot uses AI. Check for mistakes.
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
Expand Down