bugfix missing field and added alias handler functionality (with all files)#2
Open
sandromastronardi wants to merge 13 commits intoImpuls-Communicatie:masterfrom
Open
bugfix missing field and added alias handler functionality (with all files)#2sandromastronardi wants to merge 13 commits intoImpuls-Communicatie:masterfrom
sandromastronardi wants to merge 13 commits intoImpuls-Communicatie:masterfrom
Conversation
[skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some fields missing that were sent by ogone but not processed by the Request class causing the SHA to mismatch.
Aside from that I added a class for serving the form data for the alias manager (https://payment-services.ingenico.com/nl/nl/ogone/support/guides/integration%20guides/alias) (this file was missing in previous pull request)
This makes it possible to store credit card details at Ogone to use in transactions later (Batch, Ecommerce, etc...)
(don't ask my why the comparison of github is not working, i see that it just marks the big part of the file removed and re-added while it should just show the changes, but those changes are minimal.)
Groetjes uit bilzen,
Sandro