Use Flag Management Issues

[WillPower3309]

Hello, when using euse or flaggie, two popular use flag management programs, both had issues with make.conf sourcing make.conf.lto with its relative file path, as well as make.conf.lto sourcing make.conf.lto.defines with its relative path. The fix was to change my make.conf and make.conf.lto to source using absolute file paths from root. Posting this in case the devs deem it worthy to modify things to be referenced by their absolute paths, as this is a potential issue that could arise for some users

[telans]

What were the issues those programs were experiencing? It's a good idea, but I don't have issues myself

[WillPower3309]

Both exhibited the error below:

Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.8/flaggie", line 25, in <module>
    sys.exit(main(sys.argv))
  File "/usr/lib/python3.8/site-packages/flaggie/cli.py", line 192, in main
    mkconf = MakeConf(
  File "/usr/lib/python3.8/site-packages/flaggie/makeconf.py", line 537, in __init__
    self.parse(mf, path)
  File "/usr/lib/python3.8/site-packages/flaggie/makeconf.py", line 582, in parse
    self.files[fn] = self.MakeConfFile(fn, path)
  File "/usr/lib/python3.8/site-packages/flaggie/makeconf.py", line 455, in __init__
    f = codecs.open(path, 'r', 'utf8')
  File "/usr/lib/python3.8/codecs.py", line 905, in open
    file = builtins.open(filename, mode, buffering)
NotADirectoryError: [Errno 20] Not a directory: '/etc/portage/make.conf/make.conf.lto'

[jian-lin]

I have an issue here using euse.

$ sudo LANG=C euse -p www-client/firefox -E wayland
/etc/portage/make.conf: line 8: make.conf.lto: No such file or directory
Adding "www-client/firefox[wayland]" use flag in "/etc/portage/package.use/firefox"

The 8th line of /etc/portage/make.conf is source make.conf.lto.

[jian-lin]

According to this issue of flaggie, this problem is fixed by this commit, which removing the support for make.conf.

[WillPower3309]

I have an issue here using euse.

$ sudo LANG=C euse -p www-client/firefox -E wayland
/etc/portage/make.conf: line 8: make.conf.lto: No such file or directory
Adding "www-client/firefox[wayland]" use flag in "/etc/portage/package.use/firefox"

The 8th line of /etc/portage/make.conf is source make.conf.lto.

I had the same issue on euse prior to using absolute paths

[kartebi]

ufed also breaks and solution is to use absolute path both in make.conf and make.conf.lto

[WillPower3309]

@telans should I submit a pull request for this? Just wanna make sure its a wanted feature as I understand absolute paths are inherently less flexible

[telans]

Are you suggesting to just change the example in the readme? I imagine if anyone has a different sysroot they would pick it up and change it. Or maybe that wouldn't matter if running from inside a sysroot with relative paths

[WillPower3309]

Are you suggesting to just change the example in the readme? I imagine if anyone has a different sysroot they would pick it up and change it. Or maybe that wouldn't matter if running from inside a sysroot with relative paths

I would make a note in the readme and change the path in line 74 of sys-config/ltoize/files/make.conf.lto to be /etc/portage/make.conf.lto.defines over the current make.conf.lto.defines, as well as update line 15 of that file to reflect the changes. This would ensure the paths are absolute and fix any issues outlined by myself and the other commenters of this issue

[telans]

Yeah you should submit a PR, sounds like a good change

[WillPower3309]

Forgot to close :P my PR fixed this