Skip to content

Conversation

@sumashivaprasad
Copy link
Contributor

Initial review draft. Adding Tests for new code are still pending. Am working on them Existing tests are passing.

suma.shivaprasad added 25 commits September 24, 2014 17:24
Added Javadoc
@sumashivaprasad
Copy link
Contributor Author

Fixed all Test Case failures in grill-driver-cube and added UTs. Test cases failing due to Rewriter not getting inited in QueryExecutionService. Looking into it

@sumashivaprasad sumashivaprasad changed the title Grill 618 - Make Rewrite pluggable Make Rewrite layer pluggable Oct 6, 2014
@sumashivaprasad
Copy link
Contributor Author

Fixed grill server UT failures.

Grill-cli - one test is failing still . Looking into it

Failed tests:
TestGrillQueryCommands.testQueryCommands:82->testExecuteSyncQuery:224 Query failed with errorCode:126 with errorMessage: Error while processing statement: FAILED: Execution Error, return code 126 from org.apache.hadoop.hive.ql.exec.mr.MapRedTask cause:Stage-1(MAPRED): has failed! expected [true] but found [false]

Tests run: 12, Failures: 1, Errors: 0, Skipped: 0

@sumashivaprasad
Copy link
Contributor Author

The above Issues were due to JAVA_HOME not being set. All tests are passing in grill-cli as well

Results :

Tests run: 12, Failures: 0, Errors: 0, Skipped: 0

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to Lens

@ghost
Copy link

ghost commented Nov 4, 2014

Some basic observations -

  1. Change grill to lens in all places including comments
  2. All grill.* config has to be changed to lens.* config
  3. Add all new config in *default.xml and regenerate apt files by running TestGenerateConfigDoc, then add it in the PR

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is a constant pls make is private static final and all caps

@ghost
Copy link

ghost commented Nov 4, 2014

The header license template has changed, please use the latest license template.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this class have to be a singleton? I think this can be contained in LensServices instance.

@sharadag
Copy link
Contributor

sharadag commented Nov 4, 2014

lens code should be agnostic to DSL and specific command types. lets relook this.
we should be able to dynamically add a specific command handler in configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants