-
Notifications
You must be signed in to change notification settings - Fork 32
Make Rewrite layer pluggable #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added Javadoc
|
Fixed all Test Case failures in grill-driver-cube and added UTs. Test cases failing due to Rewriter not getting inited in QueryExecutionService. Looking into it |
|
Fixed grill server UT failures. Grill-cli - one test is failing still . Looking into it Failed tests: Tests run: 12, Failures: 1, Errors: 0, Skipped: 0 |
|
The above Issues were due to JAVA_HOME not being set. All tests are passing in grill-cli as well Results : Tests run: 12, Failures: 0, Errors: 0, Skipped: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to Lens
|
Some basic observations -
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is a constant pls make is private static final and all caps
|
The header license template has changed, please use the latest license template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this class have to be a singleton? I think this can be contained in LensServices instance.
|
lens code should be agnostic to DSL and specific command types. lets relook this. |
Initial review draft. Adding Tests for new code are still pending. Am working on them Existing tests are passing.