Conversation
…e function mergeConfigFrom which should do the same job
| return array_replace_recursive($items, $customItems); | ||
| }); | ||
| } | ||
| $this->mergeConfigFrom(__DIR__ . '/../config/trucker.php', 'trucker'); |
There was a problem hiding this comment.
Have you verified that these config changes are functional?
|
Thanks for digging into this! Can you take a look at TravisCI and make the necessary corrections to get the build passing and then I'll re-review? |
|
I did use it in production for a time until the project shifted to another solution and everything was working fine, but I don't have the setup to test things manually anymore. |
|
I think the testes would have to be rewritten completely, but everything seemed to work on prod. |
|
In my experience with L5 is that it's actually best to avoid writing tests for ServiceProviders since it usually relies on the IOC container. I'll fork your branch and give the tests some love. |
|
@brianwebb01 Are you ok with me making changes to this TruckerServiceProvider that make this a Laravel-only package? |
|
The world is your oyster. Do as you wish. On Tuesday, March 8, 2016, Ben Kuhl notifications@github.com wrote:
|
|
Digging deeper into this, there are a lot of dependencies that are no longer provided in some of Illuminate's package that this project relies on for the tests to pass. I'm not going to spend the time to update this project to make the tests pass because the work is significant. However I would like to make your branch available to others. Are you able to change the MR for this branch so instead of going into |
|
I can't seem to figure out how to change it, but I'll try to initiate a new one instead. |
|
Branch |
3 participants
Hi,
I had to use Trucker on a project and since I started fresh, I made the changes for Laravel 5. You might see a lot of useless commits since I was just confused about how Laravel 5 worked for config setting and getting ++ combined with the ConfigManager.php.
Everything seems to work fine for now. Since it's not a refactoring job, I left Guzzle to its original version in composer.json, but I guess someone who worked on the project could just verify if the latest version could make it.
Also, I changed only one line in the readme.md to reflect the new Laravel 5 way to publish vendor configs, but feel free to review if anything else is missing!