Skip to content

Comments

Issue #45: Asn Label cleanup#46

Open
VijayrajS wants to merge 39 commits intomasterfrom
issue-45_functional_cmp
Open

Issue #45: Asn Label cleanup#46
VijayrajS wants to merge 39 commits intomasterfrom
issue-45_functional_cmp

Conversation

@VijayrajS
Copy link
Contributor

@VijayrajS VijayrajS commented Nov 22, 2025

Changelog

  • Converted Asn.jsx to AsnLabel.jsx + AsnUtils.js (Moved helper functions to separate files for cleanliness)
  • Converted the AsnLabel to a functional component with strict props validation
  • Cleaned up code to consistently use camelCase
  • Added additional feature where private ASNs/ASNs from an unknown country have a flag with a question mark next to them, and fixed formatting of additional labels (like asndrop, private etc.)
  • Enabled React’s new automatic JSX runtime by changing the babelrc config.

(Event table and event list table)
Old UI
image
image

UI with Fix
image
image

Status

Deployed on grip-dev.

@VijayrajS VijayrajS linked an issue Nov 22, 2025 that may be closed by this pull request
@VijayrajS VijayrajS changed the title Issue 45 functional cmp Issue #45: Asn Label cleanup Dec 21, 2025
@VijayrajS VijayrajS marked this pull request as ready for review December 21, 2025 04:23
@@ -0,0 +1,99 @@
function isInRange(value, min, max) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salcock Do we have a Georgia Tech copyright comment string that we have to put up here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conversion to functional components - AsNumber

1 participant