Skip to content

Conversation

@JF002
Copy link
Contributor

@JF002 JF002 commented Dec 21, 2023

Replace the old WeatherService by the new Simple Weather Service.

Needed by InfiniTimeOrg/InfiniTime#1924.

NOTE : I'm not sure why the compiler suddenly decided to complain about the unused callback in AlertNotificationService... But I commented it out since it's not used by InfiniSim.

Replace the old WeatherService by the new Simple Weather Service.
@NeroBurner NeroBurner added the needs-InfiniTime-change PR blocked until InfiniTime upstream change is merged label Dec 23, 2023
@NeroBurner NeroBurner self-assigned this Dec 23, 2023
@NeroBurner
Copy link
Collaborator

Thanks for the update here!
Do you want to apply the latest changes from the upstream PR to the simple-weather-service files, or is the current state good enough?

@JF002
Copy link
Contributor Author

JF002 commented Dec 23, 2023

Thanks for the update here! Do you want to apply the latest changes from the upstream PR to the simple-weather-service files, or is the current state good enough?

Oh yes, sure, I'll do it right away :)

JF002 and others added 2 commits December 23, 2023 21:07
@NeroBurner NeroBurner merged commit d6cc458 into main Dec 23, 2023
@NeroBurner NeroBurner deleted the simple-weather-service branch December 23, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-InfiniTime-change PR blocked until InfiniTime upstream change is merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants