Skip to content

feature: add battery percentage display#1205

Open
lpcvoid wants to merge 1 commit intoInfiniTimeOrg:mainfrom
lpcvoid:battery-percentage
Open

feature: add battery percentage display#1205
lpcvoid wants to merge 1 commit intoInfiniTimeOrg:mainfrom
lpcvoid:battery-percentage

Conversation

@lpcvoid
Copy link

@lpcvoid lpcvoid commented Jun 28, 2022

This commit adds the option to display
battery percentage in the top of the
screen, next to the battery icon.

The toggle for this option is in the
battery info screen.

Option

Active

Please be aware that I only have a sealed watch. It works fine on the simulator, but please test this on real hardware

@yehoshuapw
Copy link
Contributor

perhaps if the percentage is displayed, the icon shouldn't be. (or some static styling to show that the percentage is of the battery)

@lpcvoid lpcvoid force-pushed the battery-percentage branch from 7d1a6f5 to fbb3d84 Compare June 28, 2022 10:15
@lpcvoid
Copy link
Author

lpcvoid commented Jun 28, 2022

I wanted to copy android's behavior here - and I think keeping the battery is more indicative of what the number represents to new users.

@yehoshuapw
Copy link
Contributor

I wanted to copy android's behavior here - and I think keeping the battery is more indicative of what the number represents to new users.

indeed, buy in android there can be lots of things on that line, where here there are much less - so it's a question of clearness vs bloatness. (and none of the options is clear cut as right)
how about the percentage, with a static battery icon under? (or just the top and bottom parts above and below)

@lpcvoid
Copy link
Author

lpcvoid commented Jun 28, 2022

I know what you envision - but I believe that the battery with a number inside would be pretty hard to read on the small display. Also, I believe that the font I am using is the smallest one generated currently.

@lpcvoid lpcvoid force-pushed the battery-percentage branch from fbb3d84 to 68193ec Compare July 11, 2022 14:03
@lpcvoid lpcvoid changed the title feature: add battery percentage display draft: add battery percentage display Jul 11, 2022
@lpcvoid lpcvoid force-pushed the battery-percentage branch 2 times, most recently from 63a2388 to 37142c0 Compare July 11, 2022 14:39
This commit adds the option to display
battery percentage in the top of the
screen, next to the battery icon.

The toggle for this option is in the
battery info screen.
@lpcvoid lpcvoid force-pushed the battery-percentage branch from 37142c0 to 5355de7 Compare July 11, 2022 14:40
@lpcvoid lpcvoid changed the title draft: add battery percentage display feature: add battery percentage display Jul 11, 2022
@lpcvoid
Copy link
Author

lpcvoid commented Jul 23, 2022

Hi folks, I'd love to have this feature upstream at some point, is anybody up for discussion?

@Riksu9000
Copy link
Contributor

There have been other implementations of this as well, such as #1028, which I slightly prefer rather than adding a global option. However I'm considering adding a percentage display to the QuickSettings screen rather than clutter the watchface.

@ghost
Copy link

ghost commented Jul 23, 2022

If I could add my 2 cents here:

Adding the percentage display to the quick settings would in my opinion not be a huge benefit to the current behavior, as the percentage could as well be viewed via the "about" screen or holding the button. The benefit of adding it directly to the watchface would be to view it with minimal user interaction.

Also I don't see the necessity to add such options as quick-settings, as a user who prefers to have the percentage displayed will usually set this once and keep the settings indefinitely.

@Riksu9000
Copy link
Contributor

By QuickSettings, I mean the screen to the left of the watchface. The watchface options is where you would customize the watchface. The issue I'm facing with adding a percentage display is that they always add a lot of clutter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants