Centralize most color definitions#1258
Merged
Riksu9000 merged 1 commit intoInfiniTimeOrg:developfrom Aug 16, 2022
Riksu9000:color-definitions
Merged
Centralize most color definitions#1258Riksu9000 merged 1 commit intoInfiniTimeOrg:developfrom Riksu9000:color-definitions
Riksu9000 merged 1 commit intoInfiniTimeOrg:developfrom
Riksu9000:color-definitions
Conversation
1 task
JF002
approved these changes
Aug 15, 2022
Collaborator
JF002
left a comment
JF002
left a comment
There was a problem hiding this comment.
LGTM.
Looks like the simulator will need to be updated according to those changes too.
NeroBurner
added a commit
to InfiniTimeOrg/InfiniSim
that referenced
this pull request
Aug 15, 2022
Support changes in InfiniTimeOrg/InfiniTime#1258 The file `lv_pinetime_theme.c` is renamed to `InfiniTimeTheme.cpp`. Need to pick up that change in the simulator to compile with the new cpp file if it exists. Furthermore use the new `InfiniTimeTheme.h` header in simulator files. Fixes: #49
NeroBurner
added a commit
to InfiniTimeOrg/InfiniSim
that referenced
this pull request
Aug 15, 2022
Support changes in InfiniTimeOrg/InfiniTime#1258 The file `lv_pinetime_theme.c` is renamed to `InfiniTimeTheme.cpp`. Need to pick up that change in the simulator to compile with the new cpp file if it exists. Furthermore use the new `InfiniTimeTheme.h` header in simulator files. Fixes: #49
Contributor
|
Supported in InfiniSim introduced with InfiniTimeOrg/InfiniSim#50 👍 |
NeroBurner
approved these changes
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed lv_pinetime_theme files to InfiniTimeTheme and made them C++.
Most colors are now defined in InfiniTimeTheme.h or use the LVGL default colors. There were a few colors unique to a single screen, which I don't think should be defined in the theme at least for now.
A few very dark colors were rounded to bgDark.
Relates to #559