Chimes: Refactor to simplify logic, make duration settable#1313
Chimes: Refactor to simplify logic, make duration settable#1313ght wants to merge 3 commits intoInfiniTimeOrg:mainfrom
Conversation
|
Do we really need a setting for this? |
|
That is up to you to decide. I'm just sharing improvements I made on my personal fork. I added this because I wanted chimes every quarter hour and because the 35ms buzz is easy to miss e.g. when you're working outdoors or doing sports, so I wanted a stronger chime buzz. If you would prefer to keep the old UI but use the refactored chime logic, just drop the last commit from this PR. Slightly off-topic, but: I didn't open this only because I want to see this in mainline InfiniTime, but because I thought it could be useful to others that remix their own forks out of the menagerie of pull requests available here :) Some I can highly recommend:
|
|
Sorry, I didn't mean to be rude. It is actually not for me to decide, because I am not a maintainer. I am also totally for a change in the chime vibrations, just so one can tell them apart. |
|
You didn't come across as rude, I didn't mean to sound offended :) I agree that the chime vibrations, along with all others, could use a rework in the long run, decoupling the apps that cause vibration from the MotorController via an intermediate VibrationController or something, which would allow centrally managing do-not-disturb/sleep-mode, priorities between vibrations (alarm clock going off while an incoming-call-notification is ringing should not be dropped, but queued until after the call), and maybe handle vibrations differently when watch is not worn, etc. |
|
I have exactly this on my todo-list! 😉 Maybe I should find time for this.. See my comment in #1223 . |
9eb465a to
be85ee4
Compare
|
I removed the new UI from this PR, so it is now only a refactoring to clean up the chimes code. |
Refactor the chimes logic to simplify it and make adding a UI to change the chime duration easier.
The only user-visible change is the addition of a "every 15 mins" option.
Size impact: -12B (400680B -> 400668B)
Edit: This used to include a redesigned UI for changing the chimes frequency and duration, but I removed that to increase the chances of the refactor getting merged. The new UI is still available at https://github.com/ght/InfiniTime/tree/chimes-ui-redesign in case anyone wants to try it out.