feat(Notifications): Adjust alert layout to show more text#1348
Closed
FrazerClews wants to merge 2 commits intoInfiniTimeOrg:developfrom
Closed
feat(Notifications): Adjust alert layout to show more text#1348FrazerClews wants to merge 2 commits intoInfiniTimeOrg:developfrom
FrazerClews wants to merge 2 commits intoInfiniTimeOrg:developfrom
Conversation
FrazerClews
force-pushed
the
frazer/notificationAlertChange
branch
from
0b74a59 to
46b0f18
Compare
Commenter25
approved these changes
Oct 16, 2022
Commenter25
left a comment
Commenter25
left a comment
There was a problem hiding this comment.
Changes seem fully functional. For anyone wondering, here's a picture of the branch with a shortened header. I personally like it, but I can easily see it feeling cramped.
|
Is there a way to slightly speed up the text as well? |
NeroBurner
approved these changes
Nov 6, 2022
Contributor
NeroBurner
left a comment
NeroBurner
left a comment
There was a problem hiding this comment.
nice improvement with minimal change, I like it
Improving the scroll speed should be done in a new PR to keep this one minimal
The firmware build is failing because of the branch name containing a / character, the PR itself seems fine
Author
|
Sorry, accidentally closed this PR trying to change the branch name, made another PR here #1422 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make better use of the space available in the header, it makes sense to increase the width of the
alert_type.To avoid confusion with the
alert_counter, a｜will separate thealert_counterfrom thealert_type.I do have a
ready which furthers this PR by making better use of the height of the header space as there is a lot of space. This allows more text in the subject content, but this may cause accessibility issues.