Feature/proper batery percentage#1397
Closed
AlexXZero wants to merge 145 commits intoInfiniTimeOrg:developfrom
Closed
Feature/proper batery percentage#1397AlexXZero wants to merge 145 commits intoInfiniTimeOrg:developfrom
AlexXZero wants to merge 145 commits intoInfiniTimeOrg:developfrom
Conversation
/home/runner/work/pinetime-lab/pinetime-lab/src/drivers/TwiMaster.cpp:1:10: fatal error: sdk/integration/nrfx/nrfx_log.h: No such file or directory #include <sdk/integration/nrfx/nrfx_log.h>
/home/runner/work/pinetime-lab/pinetime-lab/src/drivers/TwiMaster.cpp:1:10: fatal error: sdk/integration/nrfx/nrfx_log.h: No such file or directory: #include <sdk/integration/nrfx/nrfx_log.h>
# Conflicts: # doc/buildAndProgram.md
Collaborator
|
Kindly rebase on top of |
Contributor
Author
|
@Avamander Thanks for feedback, I will rebase my changes to develop + rename branch name as it looks like current name is not allowed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds linear approximation util and use it for making battery discharge curve more linear.
These changes were done independently on #585, I guess my solution is more generic. The main idea of my PR is adding linear approximation which might be used in any other feature including this old PR.
I used my own measurements of battery, not sure if they accurate enough, so you are welcome to update my digits:
My measurements:
blue - measured voltage
red - measured percentage (using 1.9.0)
orange - filtered voltage (I'm working on adding filter in another branch)
green - expected percentage using this algorithm (actually data is filtered, but it shows trade line of approximation)
I can share my data by request.