AlexXzero and hassless: approximate battery discharge curve#1444
Merged
AlexXzero and hassless: approximate battery discharge curve#1444
Conversation
Add linear approximation class and use it to better model the non-linear discharge curve of the battery. Changed the minimum voltage level to 3.5V and the maximum to 4.18V. For reference the maximum observed voltage is 4.21V during charging.
Avamander
approved these changes
Nov 19, 2022
Collaborator
|
Thanks a lot to @hassless and @AlexXZero for their work on this topic, and sorry for the time it took for me to review those PRs! |
JF002
approved these changes
Nov 19, 2022
This was referenced Nov 19, 2022
|
Thanks a lot for getting this in! I was really looking forward to this to get a better sense of when recharging is needed. ✨ |
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a squash and combination of the PRs #1398 and #585 such that both contributions of @AlexXZero and @hassless will be part of the release changes