Closed
Conversation
Rename Apps to ScreenIds to free up the name Apps for actual apps. This is meant as a first preparation step towards more dynamic apps.
|
Build size and comparison to main:
|
Change all variables in DisplayApp.h mentioning apps to be in line with the new ScreenIds.
Change all variable names to be in line with the ScreenId renaming.
Fix typo
Fix missing changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
AppstoScreenIdsto free up the nameAppsfor actual apps. This is meant as a first preparation step towards more dynamic apps.The next steps following this PR would be to implement an
Appclass and a unified interface for all apps to the system. Having this, we can build an app controller and maybe dynamic loading someday. (See #1571 for some discussion)As I see it, not every
Screenis anApp. What the enum refers to are all screens.Todos: