Heartrate app displays --- instead of 000 #1887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
FintasticMan
approved these changes
Nov 17, 2023
Member
FintasticMan
left a comment
FintasticMan
left a comment
There was a problem hiding this comment.
I think this makes it more clear to the user what the situation is.
NeroBurner
reviewed
Nov 17, 2023
Member
|
Does exactly what it says on the tin, haven't had any issues. Seems good to go UX wise to me |
NeroBurner
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1881, when the heartrate data is not clear, or there is no measurement, display --- instead of 000