Merged
Conversation
|
Build size and comparison to main:
|
Watch faces can now be selected at buid time. It's implemented in a similar way than the selection of user apps, using a list of watch face description that is generated at build time (consteval, constexpr)
JF002
force-pushed
the
watchface-selection-at-build-time
branch
from
f38b68f to
7add800
Compare
FintasticMan
requested changes
Dec 10, 2023
Member
FintasticMan
left a comment
FintasticMan
left a comment
There was a problem hiding this comment.
This looks good! Just a couple of small details.
Do not assign specific values to the fields of the enum WatchFace.
FintasticMan
approved these changes
Dec 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to select which watch faces will be built into the firmware at build time. This is done in a similar way than in #1894 : a list of watch face descriptions is generated at build time (using
constexpr/constevaland template meta programming). This list is then used at run time to build the setting menu and to load the watchface when requested by the user.Using this PR together with #1894 (which is already merged), it is now possible to build a bare minimum firmware with no user app and a single watchface. This reduces the image size from 377KB (79%) down to 311KB (65%) in flash memory.