Remove unused submodule QCBOR #2138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The submodule isn't used anymore. Remove the submodule reference completely.
|
Build size and comparison to main:
|
mark9064
approved these changes
Oct 6, 2024
Member
mark9064
left a comment
mark9064
left a comment
There was a problem hiding this comment.
Sounds good
mcuboot imgtool still relies on a python cbor library - not sure if this is used in practice either (it doesn't work without though and would need some code changes if it can be dropped)
FintasticMan
approved these changes
Oct 9, 2024
jmlich
pushed a commit
to jmlich/InfiniTime
that referenced
this pull request
Dec 22, 2024
The submodule isn't used anymore. Remove the submodule reference completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The submodule isn't used anymore. Remove the submodule reference completely.